Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: improve test for #1333 #1350

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

akinnane
Copy link
Contributor

@akinnane akinnane commented Apr 6, 2021

@hawkw Thanks for the feedback in #1333. I've been AFK for the last week but I've updated the test based on your comments from the review. It allows better coverage of the span life cycle and is easier to read.

Ref: #1333 (review)

Based on feedback by @hawkw, I've improved the test for tokio-rs#1333 to parse
the json output. This is more specifc for the bug and allows easier
testing of the different span `on_events`.

Ref: tokio-rs#1333 (review)
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@hawkw hawkw merged commit 22915a3 into tokio-rs:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants