Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement layer::Filter for Option<Filter> #2402

Closed
wants to merge 7 commits into from
Closed

Implement layer::Filter for Option<Filter> #2402

wants to merge 7 commits into from

Commits on Nov 29, 2022

  1. Fully implement Filter for Box<Filter> 

    Pass all the Filter methods through to the underlying Box/Arc Filter
rather than relying on default implementations.
    @jsgf
    jsgf committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d44660c View commit details
    Browse the repository at this point in the history

  2. Implement Filter for Option<F: Filter> 

    Where None means "no filtering".
    @jsgf
    jsgf committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d2c7a43 View commit details
    Browse the repository at this point in the history

  3. Drive-by clippy fix

    @jsgf
    jsgf committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    9d5c77c View commit details
    Browse the repository at this point in the history

  4. more clippy fixes

    @jsgf
    jsgf committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0ea1a27 View commit details
    Browse the repository at this point in the history

  5. yet more clippy fixes

    @jsgf
    jsgf committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f9fbbc6 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. Update docs to mention Option<Filter>

    @jsgf
    jsgf committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    5c7341c View commit details
    Browse the repository at this point in the history

  2. Add test for Option<Filter> on layers 

    Make sure None lets everything through.
    @jsgf
    jsgf committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    320fea8 View commit details
    Browse the repository at this point in the history