chore: new clippy/rust lints #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
requested review from
hawkw,
carllerche,
davidbarsky and
a team
as code owners
|
@dpc there's one more failure in clippy still: https://github.com/tokio-rs/tracing/actions/runs/8789287064/job/24141292737?pr=2948 |
dpc
force-pushed
the
24-04-22-clippy-fixes
branch
from
ac8b8df
to
e969db1
Compare
|
The remaining clippy failure (https://github.com/tokio-rs/tracing/actions/runs/8807729140/job/24205123089?pr=2948#step:4:825) should probably be solved with an allow attribute; I believe the |
dpc
force-pushed
the
24-04-22-clippy-fixes
branch
from
e969db1
to
be82479
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
clippy is failing with recent Rust toolchain up to 1.77.2.
Solution
Give clippy what it wants.