Fix example of using TracedError with error kind pattern #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaahc I think if we rebase onto master, CI should start passing again! |
hawkw
approved these changes
Mar 13, 2020
hawkw
added a commit
that referenced
this pull request
Oct 23, 2021
# 0.2.0 (October 23, 2021) This is a breaking change release in order to update the `tracing-subscriber` dependency version to [the v0.3.x release series][v03]. ### Changed - Updated `tracing-subscriber` dependency to [v0.3.0][v03] ([#1677]) ### Fixed - Disabled default features of the `tracing` dependency so that proc-macro dependencies are not enabled ([#1144]) - Documentation fixes and improvements ([#635], [#695]) ### Added - **SpanTrace**: Added `SpanTrace::new` constructor for constructing a `SpanTrace` from a `Span` passed as an argument (rather than capturing the current span) ([#1492]) Thanks to @CAD97 for contributing to this release! [v03]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.0 [#635]: #635 [#695]: #695 [#1144]: #1144 [#1492]: #1492 [#1677]: #1677
hawkw
added a commit
that referenced
this pull request
Oct 23, 2021
# 0.2.0 (October 23, 2021) This is a breaking change release in order to update the `tracing-subscriber` dependency version to [the v0.3.x release series][v03]. ### Changed - Updated `tracing-subscriber` dependency to [v0.3.0][v03] ([#1677]) ### Fixed - Disabled default features of the `tracing` dependency so that proc-macro dependencies are not enabled ([#1144]) - Documentation fixes and improvements ([#635], [#695]) ### Added - **SpanTrace**: Added `SpanTrace::new` constructor for constructing a `SpanTrace` from a `Span` passed as an argument (rather than capturing the current span) ([#1492]) Thanks to @CAD97 for contributing to this release! [v03]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.0 [#635]: #635 [#695]: #695 [#1144]: #1144 [#1492]: #1492 [#1677]: #1677
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.2.0 (October 23, 2021) This is a breaking change release in order to update the `tracing-subscriber` dependency version to [the v0.3.x release series][v03]. ### Changed - Updated `tracing-subscriber` dependency to [v0.3.0][v03] ([tokio-rs#1677]) ### Fixed - Disabled default features of the `tracing` dependency so that proc-macro dependencies are not enabled ([tokio-rs#1144]) - Documentation fixes and improvements ([tokio-rs#635], [tokio-rs#695]) ### Added - **SpanTrace**: Added `SpanTrace::new` constructor for constructing a `SpanTrace` from a `Span` passed as an argument (rather than capturing the current span) ([tokio-rs#1492]) Thanks to @CAD97 for contributing to this release! [v03]: https://github.com/tokio-rs/tracing/releases/tag/tracing-subscriber-0.3.0 [tokio-rs#635]: tokio-rs#635 [tokio-rs#695]: tokio-rs#695 [tokio-rs#1144]: tokio-rs#1144 [tokio-rs#1492]: tokio-rs#1492 [tokio-rs#1677]: tokio-rs#1677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The originally given example for how to use TracedError along side the Error Kind pattern was subtly incorrect. You cannot use a derive macro on the error itself because it needs to forward all implementation other than
backtrace()to its inner error type, which is not supported by the existingtransparentattribute of thiserror.