-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
My scroll wheel doesn't work at all when I scroll to the component. |
Thanks @Darksonn. Do you see any warnings or errors in the console? Which browser did you test it on? |
@Darksonn I can see it does not work in FF but it does in Chrome, tks |
@Darksonn just pushed a fix for the scrolling issue. Should work on FF now. Unfortunately, the fix was to not update the url hash when scrolling, so we lost that. Will look into it. |
Thanks for looking into this! Looks like the trigger points to transition the stack graphic isn't lined up with the sections anymore? Also, the page loads w/ all the stack components faded out instead of selected. |
@carllerche fixed the issue with the faded out components on page load. I'm not sure what you mean by the trigger points aren't lined up with the sections anymore. AFAICT, it looks exactly the same as in master or what am I missing? |
Fixed the sections alignment issue in a hacky way. It's a bit better but not ideal, I think. |
The alignment still seems a bit off, though not as bad. I may try to poke around some with this to see if I can fix it. |
Thanks for the work again! I'm going to close this as we have a solution for now and you mentioned you are lacking time right now. Either way, the work is appreciated 👍 |
This PR implements a new TokioStack component to handle animations and scrolling that were previously handled outside of react.
Scrolling is a bit janky, particularly going backwards but should be easy to fix.