Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

TokioStack component #34

Closed
wants to merge 8 commits into from
Closed

TokioStack component #34

wants to merge 8 commits into from

Conversation

alce
Copy link
Member

@alce alce commented Jun 3, 2020

This PR implements a new TokioStack component to handle animations and scrolling that were previously handled outside of react.

Scrolling is a bit janky, particularly going backwards but should be easy to fix.

@alce alce requested review from carllerche and Darksonn June 3, 2020 17:10
@alce alce changed the title [WIP] TokioStack component TokioStack component Jun 3, 2020
@Darksonn
Copy link
Contributor

Darksonn commented Jun 4, 2020

My scroll wheel doesn't work at all when I scroll to the component.

@alce
Copy link
Member Author

alce commented Jun 4, 2020

Thanks @Darksonn. Do you see any warnings or errors in the console? Which browser did you test it on?

@alce
Copy link
Member Author

alce commented Jun 4, 2020

@Darksonn I can see it does not work in FF but it does in Chrome, tks

@alce
Copy link
Member Author

alce commented Jun 4, 2020

@Darksonn just pushed a fix for the scrolling issue. Should work on FF now. Unfortunately, the fix was to not update the url hash when scrolling, so we lost that. Will look into it.

@carllerche
Copy link
Member

Thanks for looking into this!

Looks like the trigger points to transition the stack graphic isn't lined up with the sections anymore? Also, the page loads w/ all the stack components faded out instead of selected.

@alce
Copy link
Member Author

alce commented Jun 4, 2020

@carllerche fixed the issue with the faded out components on page load.

I'm not sure what you mean by the trigger points aren't lined up with the sections anymore. AFAICT, it looks exactly the same as in master or what am I missing?

@alce
Copy link
Member Author

alce commented Jun 4, 2020

Fixed the sections alignment issue in a hacky way. It's a bit better but not ideal, I think.

@carllerche
Copy link
Member

The alignment still seems a bit off, though not as bad. I may try to poke around some with this to see if I can fix it.

@carllerche
Copy link
Member

Thanks for the work again! I'm going to close this as we have a solution for now and you mentioned you are lacking time right now. Either way, the work is appreciated 👍

@carllerche carllerche closed this Jul 17, 2020
@carllerche carllerche deleted the tokio-stack branch July 17, 2020 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants