Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

fix stack link alignment #71

Merged
merged 3 commits into from
Jul 16, 2020
Merged

fix stack link alignment #71

merged 3 commits into from
Jul 16, 2020

Conversation

carllerche
Copy link
Member

No description provided.

/>
</a>
</Link>
<a href="/" className="navbar-item">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the link node disables fancy javascript prefetch stuff. This is a hacky way to resolve #34

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. Alternatively, if we have some method that is called when the prefetch thing is used, I can fix the current JS pretty easily.

@carllerche
Copy link
Member Author

@Darksonn i spent a few minutes investigating that option but gave up. It probably is not hard but I don’t know how. @alce what are your thoughts? I went this route to avoid having to fix the alignment issues your PR had. It is a hack but 🤷‍♂️

I’m going to merge for now. We can always iterate.

@carllerche carllerche merged commit f257df9 into master Jul 16, 2020
@Darksonn Darksonn deleted the tweak-stack-scroll branch July 16, 2020 18:22
@alce
Copy link
Member

alce commented Jul 17, 2020

I'm a bit tied up in other stuff atm but will look into this early next week. @Darksonn, apologies for being unresponsive with the other couple of pending issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants