Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package: add rm2fb package #143

Merged
merged 9 commits into from
Dec 23, 2020
Merged

package: add rm2fb package #143

merged 9 commits into from
Dec 23, 2020

Conversation

raisjn
Copy link
Contributor

@raisjn raisjn commented Nov 24, 2020

this adds rm2fb (ddvk/remarkable2-framebuffer) package, which is used for app compatibility on the rM2.

to run an app, first start rm2fb-server, then use rm2fb-client <app> to launch the app.

@raisjn raisjn marked this pull request as draft November 24, 2020 19:30
package/rm2fb/rm2fb-server Outdated Show resolved Hide resolved
package/rm2fb/package Outdated Show resolved Hide resolved
this adds two binaries, rm2fb-client and rm2fb-server, as well as their
two LD_PRELOAD .so files. it also adds rm2fb service that runs
rm2fb-server
@raisjn raisjn marked this pull request as ready for review December 18, 2020 00:11
@Eeems
Copy link
Member

Eeems commented Dec 19, 2020

Since I don't have a rM2 I can't test. Anybody else able to test the builds?

@lcpriest
Copy link

lcpriest commented Dec 20, 2020

Running make repo on this pr threw an error for me.

{16:01}[2.5.1]~/Development/toltec:rmkit-dev/testing ✓ ➭ make repo
./scripts/repo-build package build/package build/repo "$remote_repo"
==> Processing appmarkable
==> Processing calculator
==> Processing chessmarkable
==> Processing draft
==> Processing fingerterm
==> Processing koreader
==> Processing oxide
==> Processing plato
==> Processing reboot-guard
==> Processing recrossable
==> Processing remarkable-splash
==> Processing retris
==> Processing rm2fb
date: illegal option -- -
usage: date [-jnRu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ...
            [-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]
make: *** [repo] Error 1

If someone can give me some tips on what I should run to properly test this, I can run it on my rm2 if I can get past this blocker.

@raisjn
Copy link
Contributor Author

raisjn commented Dec 20, 2020

for testing, see ddvk/remarkable2-framebuffer#35

the build system for PRs also attaches the packages built as artifacts: it's at the bottom of the build check page: https://github.com/toltec-dev/toltec/suites/1697155072/artifacts/31910889 (for the most recent run)

for building, can you share what version of date you have? (use date --version)

@raisjn
Copy link
Contributor Author

raisjn commented Dec 23, 2020

i think enough people (5+) have installed this package and had it work for them

Copy link
Member

@Eeems Eeems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to community testing I'll approve.

@raisjn raisjn merged commit 2a8fe1e into toltec-dev:testing Dec 23, 2020
@matteodelabre matteodelabre added the packages Add or improve packages of the repository label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants