Skip to content

Conversation

tomasanchez
Copy link
Owner

This pull request introduces significant changes to the project, transitioning from poetry to uv for dependency management, updating the Python version to 3.11, and replacing several tools for linting, formatting, and testing. It also includes updates to the Docker configuration and project metadata. Below is a summary of the most important changes grouped by theme.

Dependency Management and Tooling Updates:

  • Replaced poetry with uv for dependency management, reflected in the Makefile, README.md, and Dockerfile. Commands like poetry install and poetry run are replaced with uv sync and uv run respectively. [1] [2] [3]
  • Updated the .pre-commit-config.yaml file to use pre-commit-hooks and ruff-pre-commit instead of custom hooks for tools like pylint, mypy, flake8, and isort.
  • Removed configuration files for flake8, isort, and mypy (.flake8, .isort.cfg, mypy.ini) and replaced their functionality with ruff in pyproject.toml. [1] [2] [3] [4]

Python and Dependency Updates:

  • Updated the Python version to 3.11.4 in .python-version, Dockerfile, and CI workflows in .github/workflows/build.yml. [1] [2] [3]
  • Updated project dependencies in pyproject.toml to use newer versions and restructured the file for compatibility with hatchling.

Docker and Deployment Enhancements:

  • Refactored the Dockerfile to use uv for building and managing dependencies, replacing poetry. Added caching and improved dependency installation.
  • Added a docker-compose.yaml file to simplify local development with Docker, including live-reloading support.

Codebase and Metadata Updates:

  • Updated the project version to 1.0.0 in pyproject.toml and src/template/version.py. [1] [2]
  • Simplified the README.md to reflect the transition to uv and removed outdated instructions for poetry. [1] [2]

Build and CI Improvements:

  • Simplified the Makefile by replacing poetry commands with uv equivalents and adding new targets like install, dev, format, and fix.
  • Updated the CI pipeline in .github/workflows/build.yml to use uv and Python 3.11.

tomasanchez and others added 3 commits June 14, 2025 20:54
deprecated poetry, linters and formatters removed all unused configuration files.

Signed-off-by: tsanchez <v-tsanchez@acvauctions.com>
switch to Python 3.11, improve caching, and refine Makefile targets

Signed-off-by: tsanchez <v-tsanchez@acvauctions.com>
@tomasanchez tomasanchez requested a review from Copilot June 15, 2025 00:06
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request transitions the project from poetry to uv for dependency management, updates the Python version to 3.11.4, refactors the Docker configuration, and cleans up various tool configurations.

  • Dependency management updated from poetry to uv
  • Python version upgraded and related configurations adjusted
  • Dockerfile and CI/CD workflows refactored to align with the new dependency manager

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/template/version.py Updated the application version from "0.0.1" to "1.0.0".
pyproject.toml Replaced poetry configuration with a [project] section and updated dependencies; added configuration for ruff linting via [tool.ruff].
mypy.ini, .isort.cfg, .flake8 Removed obsolete files in favor of using ruff and hatchling.
docker-compose.yaml Added a new Docker Compose file for local development with live-reloading.
README.md Updated instructions to reflect the change from poetry to uv.
Makefile Replaced poetry commands with uv equivalents and added new targets.
Dockerfile Refactored to install uv, leverage build caching, and build a self-contained virtual environment.
.python-version, .pre-commit-config.yaml, .github/workflows/build.yml Updated and aligned configuration files with the new dependency management and Python version.
Comments suppressed due to low confidence (1)

Dockerfile:8

  • The environment variable 'PYTHOPNUNBUFFERED' appears to be misspelled; consider using 'PYTHONUNBUFFERED' to properly enable unbuffered output.
PYTHOPNUNBUFFERED=1 \

tomasanchez and others added 2 commits June 14, 2025 21:07
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: tsanchez <v-tsanchez@acvauctions.com>
@tomasanchez tomasanchez merged commit 5df9abc into main Jun 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants