Allow retrieving found/DNF caches #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarhill0
force-pushed
the
found-not-found-caches
branch
from
4188fe9 to
624e46b
Compare
tomasbedrich
approved these changes
Jan 22, 2019
jarhill0
force-pushed
the
found-not-found-caches
branch
from
be3e766 to
558ed56
Compare
jarhill0
force-pushed
the
found-not-found-caches
branch
from
558ed56 to
e8f7096
Compare
|
Thanks @tomasbedrich! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to retrieve found or DNF caches. To do this, I added the ability to load a cache by GUID. Unfortunately, this method is not in the lazy-loading style because current implementations assume that all
Cacheobjects have a.wp(geocode) attribute, but this is not the case when all you have is a GUID and a title.