Skip to content

Conversation

S0S-90
Copy link
Contributor

@S0S-90 S0S-90 commented Mar 24, 2019

see #117

I have changed the function my_logs() so that if cache can be read by guid it is read by guid and otherwise -- i. e. if the cache is only for premium members -- it reads the cache by the GC code. So my_logs() doesn't throw an error and you can get the information of the caches you have found before the PMonly cache. It is even possible to get some information on the PMonly cache by cache.load_quick().

@coveralls
Copy link

coveralls commented Mar 24, 2019

Coverage Status

Coverage increased (+0.1%) to 94.517% when pulling 397b973 on S0S-90:master into b4cb385 on tomasbedrich:master.

Copy link
Owner

@tomasbedrich tomasbedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. There are some minor problems, but in general it should work nice.

Please change the history (using git rebase -i) and remove unnecessary commit + its revert.

@tomasbedrich tomasbedrich added this to the 3.8.0 milestone Mar 26, 2019
@S0S-90
Copy link
Contributor Author

S0S-90 commented Mar 27, 2019

I've tried to implement your requested changes:

  • changed history with 'git rebase -i HEAD~3'
  • read gccode from redirected url (makes function _get_gccode_from_guidpage unnecessary)
  • use self._request with stored URL to get the redirected url
  • reformated doctring

@tomasbedrich tomasbedrich merged commit b4a04e2 into tomasbedrich:master Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants