Correct lowercase coordinates #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasbedrich
requested changes
Jun 23, 2019
There was a problem hiding this comment.
Nice and simple. 👍 Just please add a test case for this and fix one minor lint error: https://travis-ci.org/tomasbedrich/pycaching/jobs/548525961#L357
Corrected comment format in geo.py. Added from_string() lowercase test in test_geo.py.
|
Sorry, this is my first contribution to GitHub and I didn't understand how
to correct the error.
I corrected the lint error and added a test case to test_geo.py, but I am
not sure what to do next.
Sorry, this is probably more work for you than if you had made the change
yourself!
…On Sun, Jun 23, 2019 at 1:47 AM Tomáš Bedřich ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Nice and simple. 👍 Just please add a test case for this and fix one
minor lint error:
https://travis-ci.org/tomasbedrich/pycaching/jobs/548525961#L357
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#124?email_source=notifications&email_token=AJHBQ65OKEP6ZEWJKWZRQXLP342CVA5CNFSM4H2L4XA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB4LFM6Y#pullrequestreview-253122171>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJHBQ63MSS3OR7MHUU4F7LDP342CVANCNFSM4H2L4XAQ>
.
|
2 similar comments
|
Acording to the message from CI: "at least two spaces before inline comment" the fix was simple - it would be sufficient to just add one space before the comment you added. :)) Thank you for the fix and test. It is probably more work for me, but hopefully it is more useful for your skills to fix these things on your own. :) |
tomasbedrich
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the correct hemisphere for an input string with lowercase characters such as "N32 46.000 w111 38.555"