Skip to content

Fix date formatting #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2020
Merged

Fix date formatting #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd61066
add workaround for systems not supporting the `-` flag for date forma…
FriedrichFroebel Jan 13, 2020
eaa8aac
replace work-around by platform detection
FriedrichFroebel Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pycaching/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env python3

import logging
import platform
import re
import warnings
import inspect
Expand Down Expand Up @@ -77,12 +78,15 @@ def format_date(date, user_date_format):
# parse user format
date_format = user_date_format.lower()
date_format = re.split("(\W+)", date_format)
# non-zero-padded numbers use different characters depending on different platforms
# see https://strftime.org/ for example
eat_zero_prefix = "#" if platform.system() == "Windows" else "-"
formats = {
"dd": r'%d',
"d": r'%-d',
"d": r'%{}d'.format(eat_zero_prefix),
"mmm": r'%b',
"mm": r'%m',
"m": r'%-m',
"m": r'%{}m'.format(eat_zero_prefix),
"yyyy": r'%Y',
"yy": r'%y',
}
Expand All @@ -92,7 +96,7 @@ def format_date(date, user_date_format):

def get_possible_attributes(*, session=None):
"""Return a dict of all possible attributes parsed from Groundspeak's website."""
# imports are here not to slow down other parts of program which normally doesn't use this method
# imports are here to not slow down other parts of program which normally don't use this method
import requests
from bs4 import BeautifulSoup

Expand Down