Skip to content

Bugfix cache types #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 3, 2020
Merged

Bugfix cache types #146

merged 4 commits into from
May 3, 2020

Conversation

CachingFoX
Copy link
Contributor

Update handling of cache types:

  • use cache type id for all types
  • extend legacy mapping cache type word to id
  • change enum name from groundspeak_hq to geocaching_hd (legacy enum is still available)
  • add missing type hq_celebration

PR includes some new test cases and cassettes.

FriedrichFroebel
FriedrichFroebel approved these changes May 3, 2020
View reviewed changes
Copy link
Collaborator

@FriedrichFroebel FriedrichFroebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FriedrichFroebel FriedrichFroebel mentioned this pull request May 3, 2020
Closed
@FriedrichFroebel FriedrichFroebel merged commit a320011 into tomasbedrich:master May 3, 2020
@CachingFoX CachingFoX deleted the bugfix-cache-types branch May 3, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FriedrichFroebel FriedrichFroebel FriedrichFroebel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CachingFoX @FriedrichFroebel