-
Notifications
You must be signed in to change notification settings - Fork 45
Add more date patterns #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more date patterns #201
Conversation
Thanks for the updated PR. Is there any reason for dropping the Line 99 in 2a6067b
Just for the record, the offending exceptions is the following one: > formatted_date = datetime.datetime.strftime(date, pattern)
E UnicodeEncodeError: 'locale' codec can't encode character '\u0433' in position 9: encoding error |
Just the Windows build was failing… |
As I promised, I fixed it... Feel free to let me know about any issues with this solution :) |
Thanks, seems legit to me. Nevertheless, I would probably prefer to avoid this overhead for Linux and macOS. Could you make the offending section conditional, please? Meaning: if platform.system() == "Windows":
# Use solution with encoding and decoding.
else:
# Use old solution. |
Sure, 8e2acd2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your fix and patience.
It seems that the date format no longer depends on the language settings. In
Settings > Preferences
, you can find aDate Format
section, where you can set a variety of date formats:This PR adds support for all of them.
Related to stale #155.