-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and improve Geocaching.search_rect()
#203
Conversation
Thanks for the PR. Could you please add a test for the reverse sort order as well? Additionally, I am not sure whether we should stay with the lowercase ordering values when calling the API or really switch to the capitalized version as in this PR. |
As I'm thinking about this now, I think we should stay with the lowercase ordering values, as the "official" requests use the lowercase. Updated in 08f6831. |
Sure, I added it right now in 14db0c7. Is it fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience.
Since we can pass parameters for reversing and limiting the returned caches directly to the URL requested by
Geocaching.search_rect()
, I believe it would be helpful (at least for me) to have these parameters accessible in Python code.I also fixed the parsing of the
userFound
property because the returned data format has changed a bit.And, of course, I reloaded the test cartridges to reflect recent changes.