Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the string to be used as a sort_by parameter in Geocaching.sort() method #228

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Allow the string to be used as a sort_by parameter in Geocaching.sort() method #228

merged 2 commits into from
Nov 29, 2023

Conversation

BelKed
Copy link
Contributor

@BelKed BelKed commented Nov 28, 2023 •
edited

Allow the string to be used as a sort_by parameter in Geocaching.sort() method

@BelKed BelKed changed the title Fix the search methods Allow the string to be used as a sort_by parameter in Geocaching.sort() method Nov 28, 2023
@FriedrichFroebel
Copy link
Collaborator

Thanks for the PR. Could you please add a corresponding test as well?

FriedrichFroebel
FriedrichFroebel approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@FriedrichFroebel FriedrichFroebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@FriedrichFroebel FriedrichFroebel merged commit d549610 into tomasbedrich:master Nov 29, 2023
15 checks passed
@BelKed BelKed deleted the sorting-fix branch November 29, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriedrichFroebel FriedrichFroebel FriedrichFroebel approved these changes

Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BelKed @FriedrichFroebel