Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findSemanticVersion method parses only first patch char #142

Closed
romanlytovchenko opened this issue Dec 12, 2022 · 1 comment
Closed

findSemanticVersion method parses only first patch char #142

romanlytovchenko opened this issue Dec 12, 2022 · 1 comment

Comments

@romanlytovchenko
Copy link

Hello Tomas,
it's really great tool, but using tag with long patch in version (like 1.2.333) works strange for me - it treats the version as 1.2.3.

I've investigate a little and find out regular expression here:

Pattern.compile("[0-9]+\\.[0-9]+\\.?[0-9]+?").matcher(tag);

My assumption what is wrong:

  • current result (marked with bold)
    printf '1.2.33333' | grep -E '[0-9]+.[0-9]+.?[0-9]+?'
    1.2.33333
  • my expected result
    printf '1.2.33333' | grep -E '[0-9]+.[0-9]+.?[0-9]+'
    1.2.33333

Also I've tested it with older lib version
npm i git-changelog-command-line@1.101.1
and get "long patch"

I hope for a quick fix if my findings are correct

@tomasbjerre
Copy link
Owner

Thanks for reporting! Should be fixed now. Open issue again if not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants