fix(cd): Properly fail deploy if CI fails #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of our continuous deployment workflow, we have a step that waits for our CI workflow to finish successfully. However, the action used to wait for the CI workflow doesn't fail on a timeout, it just sets an output variable. So, we should have an extra step to check the output and fail appropriately. Finally, we shouldn't be timing out at all. CI takes roughly 20 minutes, so I'm bumping the timeout to an hour to make sure we have plenty of time to wait for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of our continuous deployment workflow, we have a step that
waits for our CI workflow to finish successfully. However, the action
used to wait for the CI workflow doesn't fail on a timeout, it just
sets an output variable.
So, we should have an extra step to check the output and fail
appropriately.
Finally, we shouldn't be timing out at all. CI takes roughly 20
minutes, so I'm bumping the timeout to an hour to make sure we have
plenty of time to wait for that.