Skip to content

Conversation

adamantike
Copy link
Contributor

flake8 has been migrated to GitHub, and the GitLab repository has been deleted.

For existing contributors, pre-commit still works because a virtualenv with the current configured flake8 version is cached. However, cleaning up the cache and trying to run pre-commit run is enough to reproduce the issue.

`flake8` has been
[migrated to GitHub](https://twitter.com/codewithanthony/status/1378746934928699396),
and the GitLab repository has been deleted.

For existing contributors, `pre-commit` still works because a virtualenv
with the current configured `flake8` version is cached. However,
cleaning up the cache and trying to run `pre-commit run` is enough to
reproduce the issue.
@tomasfarias
Copy link
Owner

flake8 has been migrated to GitHub

TIL! Thanks for bringing this to my attention (sidenote: a lot of my projects will need updating).

@tomasfarias
Copy link
Owner

tomasfarias commented Nov 22, 2022

nit: flake8>=5 is not supported as it has dependency conflicts that cannot be resolved. However, for a pre-commit hook, it should be fine to run the latest version.

Moreover, I'm currently working on dropping support for apache-airflow<=2.0 which is a major contributor to dependency conflicts. This is coming as part of airflow-dbt-python==1.0.0 which I'm working on at the abp-v1.0.0 branch, and intend to release before end of the year.

Thanks for your contribution!

@tomasfarias tomasfarias added the bug Something isn't working label Nov 22, 2022
@tomasfarias
Copy link
Owner

Coverage issue is unrelated, badge shouldn't be updated anyways.

@tomasfarias tomasfarias merged commit 3844351 into tomasfarias:master Nov 22, 2022
@adamantike adamantike deleted the chore/flake8-url-to-github branch November 23, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants