Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troblue searching for Brazilian Portuguese subtitles #898

Closed
Blasg2 opened this issue May 4, 2024 · 2 comments
Closed

Troblue searching for Brazilian Portuguese subtitles #898

Blasg2 opened this issue May 4, 2024 · 2 comments

Comments

@Blasg2
Copy link

Blasg2 commented May 4, 2024

The subtitles exist on opensubtitles, and i tried adding some variations on uosc languages config but i'm probably writing something wrong. I tried with "pt-br" just "br".
How would the full line of the code be?

ps: i still want to keep searching in en, but also for brazilian portuguese.
ps2: idk if this is possible but it would be cool to implement a search on mpv and right click to go to the opensubtitles link for it, so the 5 subs per day limit is a little easier to deal with.

@tomasklaen
Copy link
Owner

tomasklaen commented May 4, 2024

We just use opensubtitles' v1/subtitles API endpoint with query, hash, and languages parameters.

There isn't an easy way for you to get the file hash, but you can try query + languages search yourself here: https://opensubtitles.stoplight.io/docs/opensubtitles-api/a172317bd5ccc-search-for-subtitles

And according to their language code docs, I think the code for portuguese should be pt-pt, or pt-br.

If you give me some example queries that have subtitles on opensubtitles, but uosc is not returning anything, I'd look into it. It is possible I messed up setting language parameters in our requests.

Opening opensubtitles page should be doable, once we have menu item buttons. Dunno when I'll get to it :(

tomasklaen added a commit that referenced this issue Aug 29, 2024
…in browser

An alternative way to download subtitles when your daily limit runs out.

ref #898
@tomasklaen
Copy link
Owner

Commit above adds the aforementioned "Open in browser" button.

Due to no reply and none else complaining, I'll close this for now. If someone provides an API query to opensubtitles that returns results but uosc returns nothing so I can look into it, I'll reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants