Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support Sequence.prototype.prepend #36

Merged
merged 4 commits into from
May 30, 2019
Merged

[Feature]: Support Sequence.prototype.prepend #36

merged 4 commits into from
May 30, 2019

Conversation

jtenner
Copy link
Contributor

@jtenner jtenner commented Apr 8, 2019

This pull request adds support for prepending multiple iterable sources to the current source.

It also adds support for multiple sources for the concat function to accept multiple sources.

@jtenner
Copy link
Contributor Author

jtenner commented Apr 8, 2019

All set for review @tomi!

@jtenner
Copy link
Contributor Author

jtenner commented Apr 12, 2019

Any news?

@tomi
Copy link
Owner

tomi commented Apr 14, 2019

Thank you for the contribution! It looks good. 👍 Since the change log and version bumping is based on commit messages, could you squash this into two separate commits with feat message. One for changing concat to accept multiple params, and one for the prepend

@jtenner
Copy link
Contributor Author

jtenner commented Apr 14, 2019

I'm so sorry. How do I do this?

@tomi
Copy link
Owner

tomi commented Apr 14, 2019

You can use this guide for example

@jtenner
Copy link
Contributor Author

jtenner commented Apr 15, 2019

@tomi I'll try to be more organized about my contributions from now on. Thank you for the appropriate feedback, and your patience :).

As for the commits, they are properly grouped under feat() commits as per your request.

@jtenner
Copy link
Contributor Author

jtenner commented Apr 19, 2019

It's been about five days. Any comments?

@jtenner
Copy link
Contributor Author

jtenner commented May 6, 2019

Hey @tomi, just checking in. looks like it's been 21 days now. What's the status?

@jtenner
Copy link
Contributor Author

jtenner commented May 21, 2019

Hey! I know life gets in the way and things are busy. I was just wondering if this project was abandoned? I really like it and would love to keep contributing.

If perhaps I don't hear a response, or this project has been abandoned, I might close this pull request. Sorry for the trouble!

-Josh

@tomi
Copy link
Owner

tomi commented May 30, 2019

Hey @jtenner! Once again, thank you so much for your contribution. All contributions are valuable and I highly appreciate you taking the time to contribute. I apologize you had to wait so long for this to be merged. I have not abandoned the project and I do plan to keep developing it. However, as I do this on my free time, I might not be active every single week.

P.S. There's an npm script commit defined in package.json, which I personally use when I commit something. It has a nice workflow to enforce that commit messages are how they should be.

@tomi
Copy link
Owner

tomi commented May 30, 2019

@all-contributors please add @jtenner for code,test,doc

@allcontributors
Copy link
Contributor

@tomi

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@tomi
Copy link
Owner

tomi commented May 30, 2019

@all-contributors please add @jtenner for code and test and doc

@allcontributors
Copy link
Contributor

@tomi

I've put up a pull request to add @jtenner! 🎉

@tomi tomi merged commit 56b6ee7 into tomi:master May 30, 2019
@jtenner
Copy link
Contributor Author

jtenner commented May 30, 2019

I happen to use this a lot now in personal projects because I have a bunch of react data grid controls, so this feature happened to be very useful to me.

Sorry for being impolite in my pull request. If I find another feature worth adding, I'll be happy to submit another request.

Thanks again!

@tomi
Copy link
Owner

tomi commented May 30, 2019

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tomi tomi added the released label May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants