-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Support Sequence.prototype.prepend #36
Conversation
All set for review @tomi! |
Any news? |
Thank you for the contribution! It looks good. 👍 Since the change log and version bumping is based on commit messages, could you squash this into two separate commits with |
I'm so sorry. How do I do this? |
You can use this guide for example |
@tomi I'll try to be more organized about my contributions from now on. Thank you for the appropriate feedback, and your patience :). As for the commits, they are properly grouped under |
It's been about five days. Any comments? |
Hey @tomi, just checking in. looks like it's been 21 days now. What's the status? |
Hey! I know life gets in the way and things are busy. I was just wondering if this project was abandoned? I really like it and would love to keep contributing. If perhaps I don't hear a response, or this project has been abandoned, I might close this pull request. Sorry for the trouble! -Josh |
Hey @jtenner! Once again, thank you so much for your contribution. All contributions are valuable and I highly appreciate you taking the time to contribute. I apologize you had to wait so long for this to be merged. I have not abandoned the project and I do plan to keep developing it. However, as I do this on my free time, I might not be active every single week. P.S. There's an npm script |
@all-contributors please add @jtenner for code,test,doc |
I couldn't determine any contributions to add, did you specify any contributions? |
@all-contributors please add @jtenner for code and test and doc |
I've put up a pull request to add @jtenner! 🎉 |
I happen to use this a lot now in personal projects because I have a bunch of react data grid controls, so this feature happened to be very useful to me. Sorry for being impolite in my pull request. If I find another feature worth adding, I'll be happy to submit another request. Thanks again! |
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request adds support for prepending multiple iterable sources to the current source.
It also adds support for multiple sources for the concat function to accept multiple sources.