Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify SockJS client when connecting to a STOMP URL using HTTPS #2

Merged
merged 1 commit into from
Sep 1, 2016

Conversation

dougreese
Copy link
Contributor

The sockjs_client package was modified to work better over HTTPS. See issue: nelsonsilva/sockjs-dart-client#10

This package must notify the sockjs_client when it should use a secure connection in its internal protocol detection routines. Ideally sockjs_client would do this automatically, but some non-trivial refactoring would likely be involved.

There is no change to the behavior of code using this package.

Note: The sockjs_client dependency is temporary until the updated sockjs_client package is updated on pub. If/when that happens, change the sockjs_client dependency from

  sockjs_client:
    git:
      url: git@github.com:dougreese/sockjs-dart-client.git
      ref: 0.3.0

to

  sockjs_client: '>= 0.3.0'

The sockjs_client package was modified to work better over HTTPS. See issue: nelsonsilva/sockjs-dart-client#10

This package must notify the sockjs_client when it should use a secure connection in its internal protocol detection routines.  Ideally sockjs_client would do this automatically, but some non-trivial refactoring would likely be involved.

There is no change to the behavior of code using this package.

Note: The sockjs_client dependency is temporary until the updated sockjs_client package is updated on pub.
@tomikiss tomikiss merged commit 14c286a into tomikiss:master Sep 1, 2016
@tomikiss
Copy link
Owner

tomikiss commented Sep 1, 2016

Thanks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants