Prevent *Alchemist-IEx* buffer from hanging while waiting for input #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Alchemist-IEx* buffer was hanging eg. when received a `IO.gets(:stdio)` command and had to be killed by `C-q` command. Removing lines 198-199 seems to solve this problem. This commit also removes `alchemist-iex-seen-prompt` and whole logic associated with it which seems to be obsolete from now.
|
cool~ |
|
What is wrong with this PR that needs to be fixed before it is merged @tonini ? |
|
@tonini - this fix works for me. can you please take a look at it ? |
|
Why isn't this merged yet..? It basically prevents (at least me) from using the repl in alchemist.. |
|
This happens because sometimes IEX sends color control codes before prompt. Alchemist can't find prompt and goes into infinite loop. |
|
It's all run by volunteers who sometimes have other things to do. Please refrain from comments like this. |
|
Thanks for merging @tonini <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alchemist-IEx buffer was hanging eg. when received a
IO.gets(:stdio)command and had to be killed byC-qcommand. Removing lines 198-199 seems to solve this problem.This commit also removes
alchemist-iex-seen-promptand whole logic associated with it which seems to be obsolete from now.