-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding multiple directory functionality #12
Conversation
Hi Please repost without the This seems to be Windows specific(taken from the backslash). Normally your shell should handle wildcards automatically. I'm ok with supporting this but it has to work on non-windows as well and at the moment I think it only works if wildcard is followed by a dot. I think better solution would be to just include https://github.com/isaacs/node-glob as a dependency. |
Sure, will check out Glob. Why do you leave out the semicolons though? |
Because you don't need them! Anyway, you can find plenty of discussions about whether to use them or not. I don't want to start another one. Main thing is that a repo should have a consistent style and theres no reason for conflicting all merges for something that adds no real value. |
Build passed. This has been tested on PC and Mac machines and is working as expected. Please review again. |
Issues I have with this:
I tested the wildcard inputs in Git bash under Windows and it worked fine. If you see this under Command Prompt then that is not really something I want to support(as stated in the readme). |
Would it be better to have an option to enable recursive search for the files? |
I don't think its worth it. To me the problem clearly seems to be in the broken shell implementation and has nothing to do with I think Git bash is a very good option for Windows users. In addition to to wildcards it also makes managing PATH env variable simpler, has better completion support etc. |
Fixed in #41 (v.0.6.0 on NPM) |
Specifying multiple directories with a file filter did not work. This adds that functionality.