recv: translate linkname to wire format #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chadwell <me@jedevc.com>
tonistiigi
approved these changes
Apr 18, 2024
|
@profnandaa Maybe we could get some tests for cases like this that would fail on previous version on windows. We do have tests running on windows runners so this should be possible. |
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
Apr 22, 2024
Full diff: https://github.com/tonistiigi/fsutil/compare/7525a1af2bb5..497d33b Summary changes: - tonistiigi/fsutil#195 receive: ensure callback errors are propagated - tonistiigi/fsutil#196 Fix file transfers from windows to linux fixes moby#4741 - tonistiigi/fsutil#197 recv: translate linkname to wire format Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
Apr 22, 2024
Full diff: https://github.com/tonistiigi/fsutil/compare/7525a1af2bb5..497d33b Summary changes: - tonistiigi/fsutil#195 receive: ensure callback errors are propagated - tonistiigi/fsutil#196 Fix file transfers from windows to linux fixes moby#4741 - tonistiigi/fsutil#197 recv: translate linkname to wire format Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
profnandaa
added a commit
to profnandaa/buildkit
that referenced
this pull request
Apr 22, 2024
Full diff: https://github.com/tonistiigi/fsutil/compare/7525a1af2bb5..497d33b Summary changes: - tonistiigi/fsutil#195 receive: ensure callback errors are propagated - tonistiigi/fsutil#196 Fix file transfers from windows to linux fixes moby#4741 - tonistiigi/fsutil#197 recv: translate linkname to wire format Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
tonistiigi
pushed a commit
to tonistiigi/buildkit
that referenced
this pull request
Apr 24, 2024
Full diff: https://github.com/tonistiigi/fsutil/compare/7525a1af2bb5..497d33b Summary changes: - tonistiigi/fsutil#195 receive: ensure callback errors are propagated - tonistiigi/fsutil#196 Fix file transfers from windows to linux fixes moby#4741 - tonistiigi/fsutil#197 recv: translate linkname to wire format Signed-off-by: Anthony Nandaa <profnandaa@gmail.com> (cherry picked from commit 64ea9da)
tonistiigi
pushed a commit
to tonistiigi/buildkit
that referenced
this pull request
Apr 25, 2024
Full diff: https://github.com/tonistiigi/fsutil/compare/7525a1af2bb5..497d33b Summary changes: - tonistiigi/fsutil#195 receive: ensure callback errors are propagated - tonistiigi/fsutil#196 Fix file transfers from windows to linux fixes moby#4741 - tonistiigi/fsutil#197 recv: translate linkname to wire format Signed-off-by: Anthony Nandaa <profnandaa@gmail.com> (cherry picked from commit 64ea9da)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #196 (review).
I think this is the right approach?
I'm kinda of struggling to understand what the desired interface is here - the sender is fairly straightforward, since we just host an
FSobject (which is platform-specific). The receiver is a bit harder, since it can take a filter function, and variousinclude/excludeparameters - should those functions refer to platform-specific paths? Or should they refer to unix-style wire paths?This feels like it would fix the issue where the linknames are wrong (I think this was introduced in #173, when we started explicitly converting to unix paths on the wire). Something doesn't feel right here though.