Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work at all in Emacs #46

Open
alphapapa opened this issue Sep 7, 2015 · 26 comments
Open

Doesn't work at all in Emacs #46

alphapapa opened this issue Sep 7, 2015 · 26 comments

Comments

@alphapapa
Copy link

I know Emacs doesn't support ligatures, but I was still hoping to use Fira Code in Emacs since it has less line spacing or lower line height than Fira Mono. But this is what I see when I use Fira Code in Emacs:

screenshot

@kirang89
Copy link

kirang89 commented Sep 7, 2015

That's weird. This is how Fira Code looks in my setup:

screenshot_08_09_15_01_31

@alphapapa
Copy link
Author

Hm, I just discovered that it also displays with this crazy character spacing in the KDE font manager. It's very strange, because I've installed a lot of different programming fonts, and none of them have any kind of problems like this, including Fira Mono.

I also tried using the 0.5 release, in both OTF and TTF formats, and they all have the same problem. This is very weird!

And to make it even weirder: When I open the fonts in the KDE Font Viewer, they display fine. But when I install them, they have the problem. And not a single other font I have has this problem.

And for the icing on the cake: When I install it but "disable" it in the KDE Font Manager, the preview within the Font Manager displays correctly. But when I reenable the font, the preview displays with the problem again.

@tonsky
Copy link
Owner

tonsky commented Sep 8, 2015

What about Fira Mono? Does it display okay?

On Tue, Sep 8, 2015 at 5:31 AM alphapapa notifications@github.com wrote:

Hm, I just discovered that it also displays with this crazy character
spacing in the KDE font manager. It's very strange, because I've installed
a lot of different programming fonts, and none of them have any kind of
problems like this.


Reply to this email directly or view it on GitHub
#46 (comment).

@alphapapa
Copy link
Author

Yes, it works fine.

@emmanueltouzery
Copy link

I also see the same problem with Fira Code 0.6 in emacs while Fira Mono works fine. GNU Emacs 24.5.1, Fedora 22.

@hlieberman
Copy link

Yup, can confirm this is a (very strange) bug on emacs24 on Debian.

@HiCodin
Copy link

HiCodin commented Dec 18, 2015

same issue for me as well. emacs 24.5.1 on Ubuntu 14.04

@andrelaszlo
Copy link

2016-01-14-232317_775x799_scrot

Great work on the font! Too bad it doesn't work in Emacs - it would have looked nice.
Since this seems to be an Emacs problem more than a problem with this font, maybe you can close this issue?

See this: http://emacs.stackexchange.com/questions/9586/otf-ligature-support-in-emacs

@tonsky
Copy link
Owner

tonsky commented Jan 15, 2016

@andrelaszlo are you using the latest version? It should be identical by all means to Fira Mono (I’m using the same source and the same build software), and Fira Mono was reported to work fine. Can you check please with 1.102?

@andrelaszlo
Copy link

Sorry, my bad. I was using the ancient version available in AUR.

Ligatures still don't work, but otherwise it looks fine (Emacs 24.5.1, FiraCode 1.102):

2016-01-15_102336_249x58

@HiCodin
Copy link

HiCodin commented Jan 15, 2016

same with @andrelaszlo . font works fine now but ligatures still are not working.

@andrelaszlo
Copy link

I think that ligatures are still missing from Emacs, according to the link in my first post. The double character width thing from the screenshot is fixed however, leaving us with a usable (and useful) font.

Ligatures are rendered correctly in other applications, so I guess we're stuck with the fix suggested in the README.

@lf94
Copy link

lf94 commented Jan 29, 2016

Not even the suggested fix works. I'm on Emacs-snapshot. It would be nice if it did! :)

@jethrokuan
Copy link

Ligatures still don't work for me either. Looks pretty enough now, though ligatures would be great.

@lf94
Copy link

lf94 commented Feb 14, 2016

This is not a FiraCode issue but an Emacs issue really. It's too bad Emacs isn't on a social coding platform because I would contact them then. If someone could hit up the mailing list that would be greatly appreciated.

@dgutov
Copy link

dgutov commented Feb 14, 2016

If someone could hit up the mailing list that would be greatly appreciated.

What should one hit it with?

@lf94
Copy link

lf94 commented Feb 14, 2016

Ligature support, maybe? I'm not entirely sure what this feature is called.

@dgutov
Copy link

dgutov commented Feb 14, 2016

Yes, I'm not sure how to phrase it either. But you're probably looking for M-x report-emacs-bug.

@jethrokuan
Copy link

Someone in the clojure slack channel mentioned that the osx build for emacs
has been patched with ligature support such that Fira Code works for him
out of the box, but I can't find any mention of it anywhere. Unless the
changeset is small and isolated it's unlikely vanilla emacs will introduce
ligature support anytime soon, given that they're focusing on eliminating
bugs right now
On Feb 15, 2016 1:13 AM, "Dmitry Gutov" notifications@github.com wrote:

Yes, I'm not sure how to phrase it either. But you're probably looking for M-x
report-emacs-bug.


Reply to this email directly or view it on GitHub
#46 (comment).

@xsyn
Copy link

xsyn commented Feb 15, 2016

I was using the railway-cat build on OSX El Capitan 10.11.2, and it worked
beautifully with ligatures and this font.

However since 10.11.3 I can no longer build it.

My point is that there is support in the railway-cat build, following the
instructions included.

On Mon, Feb 15, 2016 at 3:22 AM, Jethro Kuan Sheng Yuan <
notifications@github.com> wrote:

Someone in the clojure slack channel mentioned that the osx build for emacs
has been patched with ligature support such that Fira Code works for him
out of the box, but I can't find any mention of it anywhere. Unless the
changeset is small and isolated it's unlikely vanilla emacs will introduce
ligature support anytime soon, given that they're focusing on eliminating
bugs right now
On Feb 15, 2016 1:13 AM, "Dmitry Gutov" notifications@github.com wrote:

Yes, I'm not sure how to phrase it either. But you're probably looking
for M-x
report-emacs-bug.


Reply to this email directly or view it on GitHub
#46 (comment).


Reply to this email directly or view it on GitHub
#46 (comment).

[image: Avatar]

Guy Taylor

Developer

Office: (+27) 21 447 3252

Skype: guy-mymalife.com

LinkedIn: Guy Taylor https://za.linkedin.com/in/guytaylor

Twitter: @xsyn https://twitter.com/xsyn

Google+: +GuyTaylor https://plus.google.com/+GuyTaylor
[image: Cognician brand devider]

www.cognician.com

Demo Fest winner Las Vegas 2014
Leadership Accelerator wins best soft skills solution!
http://www.elearningguild.com/DevLearn/content/3438/devlearn-2014-conference--expo--elearning-demofest/

@vyp
Copy link

vyp commented Feb 17, 2016

@jethrokuan

Someone in the clojure slack channel mentioned that the osx build for emacs has been patched with ligature support such that Fira Code works for him out of the box, but I can't find any mention of it anywhere.

I don't know if this is the same thing of course, but @RadicalZephyr recently posted a patch on this issue tracker: #42 (comment)

@weavejester
Copy link

Someone in the clojure slack channel mentioned that the osx build for emacs
has been patched with ligature support such that Fira Code works for him
out of the box, but I can't find any mention of it anywhere.

It's mentioned at the bottom of the Setting up Emacs wiki page.

@tobia
Copy link

tobia commented Jul 1, 2016

I was using the railway-cat build on OSX El Capitan 10.11.2, and it worked beautifully with ligatures and this font.

@xsyn did you get any sluggishness, compared with the vanilla OS X build? I'd love to use that build, because of the ligature support and better OS X integration, but I'm getting a very unresponsive UI, especially (but not only) when scrolling.

I mean, just scroll around a file, or keep something like + (in normal mode) pressed on auto-repeat, and you'll see the scrolling jump around quite a bit, not to mention the cursor disappearing.

Can you suggest any tweak or setting to make it perform better? What version were you using?

@xsyn
Copy link

xsyn commented Jul 17, 2016

I found that turning off progressive scrolling made a huge difference for me:

(setq mouse-wheel-progressive-speed nil)

@ninrod
Copy link

ninrod commented Jan 20, 2017

see this

@felipebalbi
Copy link

I have the same issue here. Here's with Fira Mono:

image

And here's the same with Fira Code:

image

I've opened emacs with emacs -Q to make sure this wasn't caused by some problem on my configuration. I've tried with sizes 10 to 15 and it all looks the same. This is with latest Fira Code 2 installed via Arch package, emacs 26.3

felipebalbi added a commit to felipebalbi/emacs.d that referenced this issue Mar 5, 2020
I've tried switching to Fira Code on Arch as well, but for some reason
the font looks wrong. I've commented on an existing bug report
upstream (tonsky/FiraCode#46 (comment)),
for now I'll use Fira Mono.

Signed-off-by: Felipe Balbi <felipe@balbi.sh>
Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this issue Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests