Skip to content

Conversation

toomuchdesign
Copy link
Owner

What kind of change does this PR introduce?

Refactor

What is the current behaviour?

Quite easy to forget to provide a definitionPathsToGenerateFrom, which results into not generating schemas silently

What is the new behaviour?

Make definitionPathsToGenerateFrom required and log a warning when empty.

Does this PR introduce a breaking change?

What changes might users need to make in their application due to this PR?

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated
  • Relevant Changeset has been added

@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

🦋 Changeset detected

Latest commit: b45d4f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-ts-json-schema Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 5609870725

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 98.077%

Totals Coverage Status
Change from base Build 5604916749: 0.3%
Covered Lines: 35
Relevant Lines: 35

💛 - Coveralls

@toomuchdesign toomuchdesign merged commit f8961ad into master Jul 20, 2023
@toomuchdesign toomuchdesign deleted the required-definitionPathsToGenerateFrom branch July 20, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant