Skip to content

Conversation

toomuchdesign
Copy link
Owner

@toomuchdesign toomuchdesign commented Mar 31, 2024

What kind of change does this PR introduce?

Bug fix

What is the current behaviour?

#211

What is the new behaviour?

Do not convert entities with a type prop defined and not of type string (since they should be already converted)

Does this PR introduce a breaking change?

No

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated
  • Relevant Changeset has been added

Copy link

changeset-bot bot commented Mar 31, 2024

🦋 Changeset detected

Latest commit: 3d2eb05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-ts-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toomuchdesign toomuchdesign linked an issue Mar 31, 2024 that may be closed by this pull request
@coveralls
Copy link
Collaborator

coveralls commented Mar 31, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 3d2eb05 on fix-type-props
into 290b7ba on master.

@toomuchdesign toomuchdesign force-pushed the fix-type-props branch 2 times, most recently from d5802e5 to d72f69c Compare March 31, 2024 19:43
@toomuchdesign toomuchdesign merged commit c2716a5 into master Apr 1, 2024
@toomuchdesign toomuchdesign deleted the fix-type-props branch April 1, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error on "type" property
2 participants