Skip to content

Conversation

toomuchdesign
Copy link
Owner

@toomuchdesign toomuchdesign commented Apr 24, 2024

What kind of change does this PR introduce?

Refactor

What is the current behaviour?

Schemas $ref values used as unique schema identifier

What is the new behaviour?

Use internal schema ids as schema identifier.

Does this PR introduce a breaking change?

Yes. metaData.schemas keys are defined as internal schema ids instead of $refs:

  • Before: #/components/schemas/Foo
  • After: /components/schemas/Foo

Other information:

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added
  • Docs have been added / updated
  • Relevant Changeset has been added

Copy link

changeset-bot bot commented Apr 24, 2024

🦋 Changeset detected

Latest commit: 9350e0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openapi-ts-json-schema Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link
Collaborator

coveralls commented Apr 24, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling 9350e0a on id-mapper
into 179b79e on master.

@toomuchdesign toomuchdesign changed the title refactor: organize schamas internally by id instead of refactor: organise schemas internally by id instead of $ref Apr 24, 2024
@toomuchdesign toomuchdesign merged commit 89fcf87 into master Apr 24, 2024
@toomuchdesign toomuchdesign deleted the id-mapper branch April 24, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants