Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hashtags select styling in default and high contrast themes #10029

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@Gargron
Copy link
Member

Gargron commented Feb 13, 2019

Before After
image image
  • Localize text in the select component
  • Fix hover and focus styles
  • Fix menu styles and unreadable text

@Gargron Gargron force-pushed the fix-hashtags-select branch from eefb6d9 to c1e4900 Feb 13, 2019

@Gargron Gargron force-pushed the fix-hashtags-select branch from c1e4900 to 3a60f49 Feb 13, 2019

@ThibG

ThibG approved these changes Feb 13, 2019

@Gargron Gargron merged commit 169b9d4 into master Feb 13, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-hashtags-select branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.