New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Nginx config for Nanobox apps #9310

Merged
merged 1 commit into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@danhunsaker
Collaborator

danhunsaker commented Nov 19, 2018

The Nanobox files have gotten out of sync, a touch, with what Masto needs for Nginx settings. This PR updates them accordingly.

Update Nginx config for Nanobox apps
The Nanobox files have gotten out of sync, a touch, with what Masto needs for Nginx settings. This PR updates them accordingly.
@Gargron

This comment has been minimized.

Member

Gargron commented Nov 19, 2018

Oops, I forgot they were there! There are now example configs in dist/, could they be re-used here somehow?

@danhunsaker

This comment has been minimized.

Collaborator

danhunsaker commented Nov 19, 2018

Unfortunately not. Routing between components (web vs streaming) is handled before any component's Nginx service sees anything, so at best the bits about routing between components would be superfluous. More importantly, though, SSL is handled at the load balancer (each app gets its own LB), so each component's Nginx service needs to listen via HTTP on port 8080; Nanobox web components never see incoming connections on port 80 or 443. That means the 80→443 redirect needs to be rewritten to check the standard proxy header X-Forwarded-Proto and redirect if the value isn't https. It also means the SSL directives need to be removed entirely. Throw in the fact that the on-disk paths are different.... It's simpler to maintain these separately, in my experience.

@Gargron Gargron merged commit 1f7311b into tootsuite:master Nov 20, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

Gargron added a commit that referenced this pull request Nov 23, 2018

Update Nginx config for Nanobox apps (#9310)
The Nanobox files have gotten out of sync, a touch, with what Masto needs for Nginx settings. This PR updates them accordingly.

@danhunsaker danhunsaker deleted the danhunsaker:fix/nanobox-nginx branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment