This repository was archived by the owner on Jan 23, 2025. It is now read-only.
use challenge service v3 #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyhit
reviewed
Aug 14, 2017
| if (parameters != null) { | ||
| for (String key : parameters.keySet()) { | ||
| builder.setParameter(key, parameters.get(key)); | ||
| if ("filter".equals(key)) { |
There was a problem hiding this comment.
@deedee this will translate the filter parameters properly?
There was a problem hiding this comment.
Yes. I've tried with all filter params
There was a problem hiding this comment.
@deedee hmm, I am not sure I understand correctly, but for filter parameter, it should be able to support multiple filtering options, is that mean for web page, we just send only one filtering?
There was a problem hiding this comment.
Yes it support multiple filtering. As you can see on challenge service all filter wrap on one paramater(which is filter)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.