Skip to content

fix(PM-1464): Copilot applications list breaks when a copilot lacks stats #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2025
Merged

fix(PM-1464): Copilot applications list breaks when a copilot lacks stats #1128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3e6a65
fix: null check for copilot stats
hentrymartin Jul 8, 2025
edddfa0
fix: null check for copilot stats
hentrymartin Jul 8, 2025
06a863b
fix: null check for copilot stats
hentrymartin Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ workflows:
- LVT-256
- CORE-635
- feat/system-admin
- pm-1464

- deployQa:
context: org-global
Expand Down
4 changes: 2 additions & 2 deletions src/apps/copilots/src/services/members.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export const getMembersByUserIds = async (

const membersFactory = (members: Member[]): FormattedMembers[] => members.map(member => ({
...member,
activeProjects: member.stats.find(item => item.COPILOT.activeProjects)?.COPILOT.activeProjects || 0,
copilotFulfillment: member.stats.find(item => item.COPILOT.fulfillment)?.COPILOT.fulfillment || 0,
activeProjects: member.stats?.find(item => item.COPILOT?.activeProjects)?.COPILOT?.activeProjects || 0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if member.stats is an array before using find to avoid potential runtime errors if member.stats is not an array.

copilotFulfillment: member.stats?.find(item => item.COPILOT?.fulfillment)?.COPILOT?.fulfillment || 0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider checking if member.stats is an array before using find to avoid potential runtime errors if member.stats is not an array.

}))

/**
Expand Down