fix(PM-1470): show applications count in tab #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -261,7 +261,7 @@ const CopilotOpportunityDetails: FC<{}> = () => { | |||
| <TabsNavbar | |||
| defaultActive={activeTab} | |||
| onChange={handleTabChange} | |||
| tabs={getCopilotDetailsTabsConfig(isAdminOrPM)} | |||
| tabs={getCopilotDetailsTabsConfig(isAdminOrPM, copilotApplications?.length || 0)} | |||
There was a problem hiding this comment.
The function getCopilotDetailsTabsConfig now takes an additional parameter. Ensure that this function is updated to handle the new parameter correctly and that all calls to this function throughout the codebase are updated accordingly.
| @@ -5,14 +5,18 @@ export enum CopilotDetailsTabViews { | |||
| applications = '1', | |||
| } | |||
|
|
|||
| export const getCopilotDetailsTabsConfig = (isAdminOrPM: boolean): TabsNavItem[] => (isAdminOrPM ? [ | |||
| export const getCopilotDetailsTabsConfig = (isAdminOrPM: boolean, count: number): TabsNavItem[] => (isAdminOrPM ? [ | |||
There was a problem hiding this comment.
The function getCopilotDetailsTabsConfig now takes an additional parameter count, but it is not used within the function. Ensure that count is utilized appropriately to fulfill the purpose of showing applications count in the tab.
...ps/copilots/src/pages/copilot-opportunity-details/tabs/config/copilot-details-tabs-config.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-1470
What's in this PR?