Skip to content

Update Review Management Page: Add Submission End Date Column #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2025
Merged

Update Review Management Page: Add Submission End Date Column #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...apps/admin/src/lib/components/ReviewSummaryList/MobileListView/MobileListView.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,12 @@

.row2,
.row3,
.row4 {
.row4,
.row5 {
grid-template-columns: 1fr auto;
}

.row5 {
.row6 {
justify-content: flex-end;
}
}
Expand Down
13 changes: 8 additions & 5 deletions src/apps/admin/src/lib/components/ReviewSummaryList/MobileListView/MobileListView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,16 +73,19 @@ const MobileListView: FC<MobileListViewProps<ReviewSummary>> = props => {
<div className={styles.row2}>
{/* Legacy ID */ propertyElements[1]}
</div>
<div className={styles.row3}>
{/* propertyElementLabels[5] */}
{/* Open Review Opp' */ propertyElements[3]}
<div className={styles.row3}>
{/* Submission End Date */ propertyElements[3]}
</div>
<div className={styles.row4}>
{propertyElementLabels[4]}
{/* Review Applications */ propertyElements[4]}
{/* Open Review Opp' */ propertyElements[4]}
</div>
<div className={styles.row5}>
{/* Action */ propertyElements[5]}
{propertyElementLabels[5]}
{/* Review Applications */ propertyElements[5]}
</div>
<div className={styles.row6}>
{/* Action */ propertyElements[6]}
</div>
</div>
</div>
Expand Down
30 changes: 15 additions & 15 deletions src/apps/admin/src/lib/components/ReviewSummaryList/ReviewSummaryList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { Paging } from '../../models/challenge-management/Pagination'

import { MobileListView } from './MobileListView'
import styles from './ReviewSummaryList.module.scss'
import { format } from 'date-fns';

export interface ReviewListProps {
reviews: ReviewSummary[]
Expand Down Expand Up @@ -98,21 +99,20 @@ const ReviewSummaryList: FC<ReviewListProps> = props => {
},
// I think this column is important, and it exits in `admin-app`
// but resp does not have it, so I just comment it here
// {
// label: 'Submission End Date',
// propertyName: 'submissionEndDate',
// renderer: (review: ReviewSummary) => (
// // eslint-disable-next-line jsx-a11y/anchor-is-valid
// <div className={styles.submissionDate}>
// {review.submissionEndDate}
// {/* {format(
// new Date(review.submissionEndDate),
// 'MMM dd, yyyy HH:mm'
// )} */}
// </div>
// ),
// type: 'element',
// },
{
label: 'Submission End Date',
propertyName: 'submissionEndDate',
renderer: (review: ReviewSummary) => (
// eslint-disable-next-line jsx-a11y/anchor-is-valid
<div className={styles.submissionDate}>
{review.submissionEndDate ?
format(
new Date(review.submissionEndDate),
'MMM dd, yyyy HH:mm') : 'N/A'}
</div>
),
type: 'element',
},
{
columnId: 'OpenReviewOpp',
label: 'Open Review Opp',
Expand Down