TCA-920 TCA - enroll payments -> dev #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testflyjets
reviewed
Mar 13, 2023
testflyjets
reviewed
Mar 13, 2023
.../tools/learn/certification-details/enrollment-page/enroll-payment-form/EnrollPaymentForm.tsx
Show resolved
Hide resolved
testflyjets
reviewed
Mar 13, 2023
.../tools/learn/certification-details/enrollment-page/enroll-payment-form/EnrollPaymentForm.tsx
Outdated
Show resolved
Hide resolved
vas3a
reviewed
Mar 13, 2023
| = Number((props.product?.default_price.unit_amount || 0) / 100) | ||
| .toFixed(2) | ||
|
|
||
| const [formFieldValues, setFormValues]: [any, Dispatch<SetStateAction<any>>] = useState<any>({ |
There was a problem hiding this comment.
I see you removed enrollment-page/enrollment-form/index.ts.
Can we keep all the form functionality in enrollment-page/enrollment-form/index.ts ? This way we have each file (component) with it's own concern/functionality.
Other than that, looks good 👍
testflyjets
reviewed
Mar 13, 2023
...s/tools/learn/certification-details/enrollment-page/enrollment-sidebar/EnrollmentSidebar.tsx
Outdated
Show resolved
Hide resolved
testflyjets
suggested changes
Mar 13, 2023
testflyjets
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables TCA - enroll payments behind feature flag
REACT_APP_ENABLE_TCA_CERT_MONETIZATION.Still WIP is final copy/flow and etc version which needs to be discussed with team & UX.