Issue #131 #137
Merged
Issue #131 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
architectt1
commented
Jul 28, 2018
architectt1
commented
- Added fileUrl when sending a PROJECT_FILE_UPLOADED event to the bus api.
- Added connectProjectsUrl config var to test.json, as it's needed for running tests.
… api. - Added connectProjectsUrl config var to test.json, as it's needed for running tests.
vikasrohit
reviewed
Jul 28, 2018
config/test.json
Outdated
| @@ -12,6 +12,7 @@ | |||
| "timelineDocType": "timelineV4" | |||
| }, | |||
| "rabbitmqUrl": "amqp://localhost:5672", | |||
| "connectProjectsUrl": "https://local.topcoder-dev.com/projects/", | |||
There was a problem hiding this comment.
Can we set default values in all other configs as well? That would make setting this as env variable optional.
There was a problem hiding this comment.
Sure, done in 84b9fed.
vikasrohit
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.