Skip to content

Changes for Topcoder Project Service Search Enhancements #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions src/routes/projects/list.js
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,28 @@ var _retrieveProjects = (req, criteria, sort, fields) => {
let retrieveAttachments = !req.query.fields || req.query.fields.indexOf('attachments') > -1
let retrieveMembers = !req.query.fields || !!fields.project_members.length


// special handling for name filter
if (_.has(criteria.filters, 'name')) {
criteria.filters.name = { ilike: `%${criteria.filters.name}%`}
// special handling for keyword filter
if (_.has(criteria.filters, 'keyword')) {
criteria.filters.$or = [
{
name: {
$ilike: `%${criteria.filters.keyword}%`
},
}, {
description: {
$ilike: `%${criteria.filters.keyword}%`
},
}, {
details: {
utm: {
code: {
$ilike: `%${criteria.filters.keyword}%`
}
}
}
}
]
delete criteria.filters.keyword
}

return models.Project.findAndCountAll({
Expand Down Expand Up @@ -117,7 +135,7 @@ module.exports = [
'name', 'name asc', 'name desc',
'type', 'type asc', 'type desc'
]
if (!util.isValidFilter(filters, ['id', 'status', 'type', 'memberOnly', 'name']) ||
if (!util.isValidFilter(filters, ['id', 'status', 'type', 'memberOnly', 'keyword']) ||
(sort && _.indexOf(sortableProps, sort) < 0)) {
util.handleError('Invalid filters or sort', null, req, next)
}
Expand Down
86 changes: 84 additions & 2 deletions src/routes/projects/list.spec.js
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@ describe('LIST Project', () => {
name: 'test1',
description: 'test project1',
status: 'active',
details: {},
details: {
utm: {
code: 'code1'
}
},
createdBy: 1,
updatedBy: 1
}).then(p => {
Expand Down Expand Up @@ -175,6 +179,84 @@ describe('LIST Project', () => {
done()
})
})
})

it('should return all projects that match when filtering by name', done => {
request(server)
.get('/v4/projects/?filter=keyword%3Dtest')
.set({
'Authorization': 'Bearer ' + testUtil.jwts.admin
})
.expect('Content-Type', /json/)
.expect(200)
.end(function(err, res) {
if (err) {
return done(err)
}
var resJson = res.body.result.content
should.exist(resJson)
resJson.should.have.lengthOf(3)
done()
})
})

it('should return the project when filtering by keyword, which matches the name', done => {
request(server)
.get('/v4/projects/?filter=keyword%3D1')
.set({
'Authorization': 'Bearer ' + testUtil.jwts.admin
})
.expect('Content-Type', /json/)
.expect(200)
.end(function(err, res) {
if (err) {
return done(err)
}
var resJson = res.body.result.content
should.exist(resJson)
resJson.should.have.lengthOf(1)
resJson[0].name.should.equal('test1')
done()
})
})

it('should return the project when filtering by keyword, which matches the description', done => {
request(server)
.get('/v4/projects/?filter=keyword%3Dproject')
.set({
'Authorization': 'Bearer ' + testUtil.jwts.admin
})
.expect('Content-Type', /json/)
.expect(200)
.end(function(err, res) {
if (err) {
return done(err)
}
var resJson = res.body.result.content
should.exist(resJson)
resJson.should.have.lengthOf(3)
done()
})
})

it('should return the project when filtering by keyword, which matches the details', done => {
request(server)
.get('/v4/projects/?filter=keyword%3Dcode')
.set({
'Authorization': 'Bearer ' + testUtil.jwts.admin
})
.expect('Content-Type', /json/)
.expect(200)
.end(function(err, res) {
if (err) {
return done(err)
}
var resJson = res.body.result.content
should.exist(resJson)
resJson.should.have.lengthOf(1)
resJson[0].name.should.equal('test1')
done()
})
})
})

})
2 changes: 1 addition & 1 deletion swagger.yaml
100644 → 100755
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ paths:
- type
- status
- memberOnly
- name
- keyword
- name: sort
required: false
description: |
Expand Down