Skip to content

Fix for issue-381 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2019
Merged

Fix for issue-381 #382

merged 3 commits into from
Oct 3, 2019

Conversation

r0hit-gupta
Copy link
Contributor

Changes for #381

@r0hit-gupta r0hit-gupta mentioned this pull request Sep 19, 2019
Closed
maxceem
maxceem suggested changes Sep 24, 2019
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r0hit-gupta changes looks good to me though there are is a couple of moments.

  1. Unit tests doesn't pass for me. How about you?

    image

  2. You use user member2 for testing that user gets error 403 when updating start/complete date. But this user doesn't have permissions to update milestone at all, see unit test above the new unit tests:

    image

    This means that unit test doesn't actually test that normal user cannot update start/complete date. To test it properly you have to use some user which CAN update milestone but is not admin. You can find such users in unit tests, for example testUtil.jwts.manager and testUtil.jwts.copilot.

@maxceem
Copy link
Contributor

maxceem commented Sep 28, 2019

Hey @r0hit-gupta please, have a look on the review above. Would you be able to complete this issue?

maxceem
maxceem suggested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update @r0hit-gupta.

One unit test is still falling for me, how about you?

image

@r0hit-gupta
Copy link
Contributor Author

@maxceem I have updated the PR. Please review.

maxceem
maxceem approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works good now. Thanks @r0hit-gupta.

@maxceem maxceem changed the base branch from cf19 to dev October 2, 2019 05:00
@maxceem
Copy link
Contributor

maxceem commented Oct 2, 2019

@vikasrohit as we already released, I think we can merge this PR directly to dev branch for the next release. It doesn't have critical functionality.

@maxceem maxceem requested a review from vikasrohit October 2, 2019 05:02
vikasrohit
vikasrohit approved these changes Oct 3, 2019
View reviewed changes
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vikasrohit vikasrohit merged commit 1cee66e into topcoder-platform:dev Oct 3, 2019
maxceem added a commit that referenced this pull request Nov 7, 2019
@maxceem
Merge pull request #382 from r0hit-gupta/issue-381-fix
050c2dd 
Fix for issue-381
@snyk-bot snyk-bot mentioned this pull request Jan 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Feb 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@maxceem maxceem maxceem approved these changes

@vikasrohit vikasrohit vikasrohit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r0hit-gupta @maxceem @vikasrohit