Skip to content

Prod 3264 integrate wp v #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 23, 2022

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Dec 21, 2022

@brooketopcoder this would be my approach on it. the logic is that we keep all the goods of the usual workflow:

  • imports are relative to lib
  • types are kept as before
  • the build output will use only the corresponding path (when you run build only the prod path will be output)

Also updated the scripts in package json and made the "build" script to build for production and "build:dev" to build for development. If you want to dinamically specify the NODE_ENV (target env actually) you can run

$ NODE_ENV=<production|development> npm run build:base

@vas3a vas3a requested a review from brooketopcoder December 21, 2022 14:12
@vas3a vas3a self-assigned this Dec 21, 2022
… dev env. It also adds the full footer to the demo app. It also adds CORS for local Wordpress. It refactors the NavItem model to only use URLs and not paths. It also fixes the nav item label to be optional. #time 8h
@brooketopcoder brooketopcoder merged commit 30b3bd8 into PROD-3264_integrate-wp Dec 23, 2022
@brooketopcoder brooketopcoder deleted the PROD-3264_integrate-wp_v branch December 23, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants