Skip to content

Conversation

CDharmateja
Copy link
Contributor

@CDharmateja CDharmateja mentioned this pull request Jan 9, 2021
@CDharmateja CDharmateja changed the title groups filter from api WIP: groups filter from api Jan 10, 2021
@CDharmateja CDharmateja changed the title WIP: groups filter from api groups filter from api Jan 10, 2021
@maxceem maxceem changed the base branch from develop to cf-jan-2021 January 12, 2021 07:09
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @CDharmateja, great solution. There are just a few minor things:

  1. The text inside the Select is slightly right now, so we cannot put cursor in the beginning

    image

    we the text inside select should be more on left and aligned with the text inside the list as it was before:

    image

    Similar the space on the left for the placeholder is too big:

    image

    and after values select it becomes too small:

    image

  2. If I choose some values for Groups and Tags, save the challenge and reload the page, then they become empty, but they should show the saved values. See demo video https://monosnap.com/file/mL5SIExoRLgoIbFQHXDknsoncUAcGC

    image

@CDharmateja
Copy link
Contributor Author

@maxceem completed the requested changes

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CDharmateja all is perfect now, thanks.

@maxceem maxceem merged commit ca73946 into topcoder-platform:cf-jan-2021 Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants