Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed travis build file #216

Merged
merged 2 commits into from
Aug 11, 2015
Merged

fixed travis build file #216

merged 2 commits into from
Aug 11, 2015

Conversation

jtilly
Copy link
Contributor

@jtilly jtilly commented Aug 11, 2015

I fixed the travis build file after seeing your question here. R CMD check --as-cran is looking for packages (that are not explicitly stated as dependency) in /usr/lib/R/library. I then use the "old school" travis setup to install dependencies in /usr/lib/R/library so they can be found. I'm also installing a bunch of dependent packages as binaries to make the build faster.

@zachmayer
Copy link
Collaborator

Thank you for fixing this! 2 requests:

  1. Fix merge conflicts. I was also working on the .travis.yml file, but you can just resolve the conflicts by discarding all changes on master and replacing them with your file.
  2. Add the coveralls line back in, and the coveralls install_github:
after_success:
  - Rscript -e 'library(covr);coveralls()'

THANKS SO MUCH! This has been bothering me for weeks.

@jtilly
Copy link
Contributor Author

jtilly commented Aug 11, 2015

I fixed the merge conflicts and added coveralls support.

@zachmayer
Copy link
Collaborator

THANKS!

zachmayer added a commit that referenced this pull request Aug 11, 2015
fixed travis build file
@zachmayer zachmayer merged commit a6318cf into topepo:master Aug 11, 2015
@zachmayer
Copy link
Collaborator

Out of curiosity, during ./travis-tool.sh bootstrap, is it skipping the latex bootstrapping step? I'd like to avoid latex if possible, as we're skipping manual and vignette building.

@jtilly
Copy link
Contributor Author

jtilly commented Aug 11, 2015

Yes, the current version is skipping the latex bootstrapping step. As long as the environmental variable BOOTSTRAP_LATEX is not set, no latex distribution will be installed.

@zachmayer
Copy link
Collaborator

Great. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants