Feature/new lib routes #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cscatolini
reviewed
Oct 16, 2018
lib/lib.go
Outdated
| @@ -42,9 +42,9 @@ func getHTTPClient(timeoutMs int) *http.Client { | |||
|
|
|||
| // NewKhan returns a new khan API application | |||
| func NewKhan(config *viper.Viper) KhanInterface { | |||
| config.SetDefault("khan.timeout", 1000) | |||
| config.SetDefault("khan.timeout", 1*time.Second) | |||
There was a problem hiding this comment.
Isn't it too big for a default value?
lib/lib.go
Outdated
| ) error { | ||
| route := k.buildInviteForMembershipURL(payload.ClanID) | ||
| _, err := k.sendTo(ctx, "POST", route, payload) | ||
| return err |
There was a problem hiding this comment.
Are you sure we won't need the reply for this and other methods such as ApproveDenyMembershipApplication? I would rather return the response everywhere and the client application can choose to ignore it if necessary.
There was a problem hiding this comment.
You're right! This also reduces the possibility of breaking changes. I will change it
cscatolini
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the remaining khan api routes on lib