-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching retrieveClansSummaries responses #56
Caching retrieveClansSummaries responses #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a first pass, let me know your thoughts. Bear in mind that this is the first time I've looked at this code, so there's a lot of context that I'm missing.
Please add a description to the PR explaining what the problem is and how we're attempting to solve it. |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes and for the added PR description, @matheuscscp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Looks Good To Me).
Please wait for Camila's approval, but otherwise feel free to merge. 👍
Feel free to merge if you think this is ready or once you've incorporated the latest suggestions by Alan. |
Problem: retrieveClansSummaries fetches a lot of data for many clans in most use cases (clan rankings). On a load test we detected that database CPU usage reaches 100% with a small load (compared to the load we expect for the launch of our next game).
Solution: Cache clans summaries individually, because players are used to rankings with information a little bit delayed.