Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MongoDB migrations CLI command #57

Merged
merged 7 commits into from
Sep 12, 2019
Merged

MongoDB migrations CLI command #57

merged 7 commits into from
Sep 12, 2019

Conversation

matheuscscp
Copy link
Contributor

@matheuscscp matheuscscp commented Sep 12, 2019 •
edited
Loading

Problem: We don't have a unified method to run MongoDB migrations.

Solution: Have a CLI command to do that.

cscatolini
cscatolini reviewed Sep 12, 2019
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions to be answered before we can merge this.

cmd/migrate_mongo.go Outdated Show resolved Hide resolved
cmd/migrate_mongo.go Outdated Show resolved Hide resolved
cmd/migrate_mongo.go Outdated Show resolved Hide resolved
cmd/migrate_mongo.go Show resolved Hide resolved
mongo/helpers.go Show resolved Hide resolved
cscatolini
cscatolini approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@cscatolini cscatolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for changing the logs :)

@cscatolini cscatolini merged commit 5f0c8e7 into topfreegames:master Sep 12, 2019
@matheuscscp matheuscscp deleted the feature/mongo-migrations branch September 12, 2019 19:53
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 61.546% when pulling 40a4c61 on matheuscscp:feature/mongo-migrations into 132fdd1 on topfreegames:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cscatolini cscatolini cscatolini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheuscscp @coveralls @cscatolini