-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HealthController] Perform rolling update of scheduler versions #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hspedro
force-pushed
the
refactor/switchversion-not-delete
branch
2 times, most recently
from
May 22, 2024 00:18
a9bc814
to
1ca2dd7
Compare
hspedro
force-pushed
the
refactor/switchversion-not-delete
branch
2 times, most recently
from
June 5, 2024 17:51
d8c366e
to
bcfce98
Compare
hspedro
force-pushed
the
refactor/switchversion-not-delete
branch
from
June 6, 2024 17:14
21372cd
to
9388674
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 64.30% 64.27% -0.03%
==========================================
Files 39 39
Lines 2905 2911 +6
==========================================
+ Hits 1868 1871 +3
- Misses 909 913 +4
+ Partials 128 127 -1 ☔ View full report in Codecov by Sentry. |
hspedro
force-pushed
the
refactor/switchversion-not-delete
branch
4 times, most recently
from
June 7, 2024 19:28
dfbc13c
to
c050115
Compare
gmurayama
approved these changes
Jun 10, 2024
hspedro
force-pushed
the
refactor/switchversion-not-delete
branch
from
June 10, 2024 13:53
c050115
to
83d132d
Compare
joaobologna
reviewed
Jun 10, 2024
hspedro
force-pushed
the
refactor/switchversion-not-delete
branch
3 times, most recently
from
June 14, 2024 18:09
b829339
to
1abf37d
Compare
hspedro
force-pushed
the
refactor/switchversion-not-delete
branch
5 times, most recently
from
June 26, 2024 19:15
a71052f
to
3f61ae3
Compare
The switch version operation will just update the scheduler version. Let healthcontroller perform the rolling update
It is now responsibility of the healthcontroller to perform a rolling update. When there was a switch on the current scheduler active version we need to rollout pods with the new version. Health controller either does autoscaling or rolling update. On rolling update, the following will happen: 1. Are there rooms with a previous scheduler version? If so, start update 2. Compute how many rooms we can surge 3. Enqueue priority operation to create this rooms 4. Check how many Ready rooms we have above desired from autoscaling 5. Enqueue operation to delete those rooms - they are a buffer, should never offend readyTarget
Add reference to the new Rolling Update mechanism performed by the health_controller operation
hspedro
force-pushed
the
refactor/switchversion-not-delete
branch
from
July 3, 2024 17:29
3f61ae3
to
aef5850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now responsibility of the healthcontroller to perform a rolling update. When there was a switch on the current scheduler active version we need to rollout pods with the new version. Health controller either does autoscaling or rolling update.
On rolling update, the following will happen:
1. Are there rooms with a previous scheduler version? If so, start
update
2. Compute how many rooms we can surge (above desired from autoscaling)
3. Enqueue priority operation to create this rooms
4. Check how many Ready rooms we have above desired from autoscaling
5. Enqueue operation to delete those rooms - they are a buffer, should
never offend readyTarget
refactor(switchversion): do not replace pods
The switch version operation will just update the scheduler version.
Let healthcontroller perform the rolling update