Refactor/ensure correct rooms #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lftakakura
commented
Aug 20, 2019
lftakakura
commented
- Now watcher's EnsureCorrectRooms replaces pods using rolling strategy.
- When an updateConfig needs a rollback, the API only rolls back the scheduler on database. EnsureCorrectRooms should then replace pods asynchronously.
lftakakura
force-pushed
the
refactor/ensure-correct-rooms
branch
from
08af55e
to
3c95db0
Compare
yuriabrito
suggested changes
Aug 20, 2019
yuriabrito
reviewed
Aug 20, 2019
henrod
suggested changes
Aug 20, 2019
| podsToDelete := []string{} | ||
| concat := func(podNames []string, err error) error { | ||
| podsToDelete := []v1.Pod{} | ||
| concat := func(pods []v1.Pod, err error) error { |
There was a problem hiding this comment.
It's better to use pointer to struct than the struct itself
cscatolini
approved these changes
Aug 20, 2019
|
@ghostec and @henrod do you guys still have remarks with this PR or are we good to go? |
henrod
approved these changes
Aug 21, 2019
lftakakura
added a commit
that referenced
this pull request
Oct 11, 2019
* Fix ListSchedulerLocks function * Refactor EnsureCorrectRooms method * Remove use of global lock i UpdateSchedulerConfig * Instantiate clock on EnsureCorrectRooms * Not using global lock in UpdateSchedulerConfig
lftakakura
added a commit
that referenced
this pull request
Oct 15, 2019
* Fix ListSchedulerLocks function * Refactor EnsureCorrectRooms method * Remove use of global lock i UpdateSchedulerConfig * Instantiate clock on EnsureCorrectRooms * Not using global lock in UpdateSchedulerConfig
lftakakura
added a commit
that referenced
this pull request
Oct 15, 2019
* Fix ListSchedulerLocks function * Refactor EnsureCorrectRooms method * Remove use of global lock i UpdateSchedulerConfig * Instantiate clock on EnsureCorrectRooms * Not using global lock in UpdateSchedulerConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.