Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/v2 history #12

Merged
merged 6 commits into from
Jul 5, 2021
Merged

Add/v2 history #12

merged 6 commits into from
Jul 5, 2021

Conversation

flapezoti
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jul 5, 2021 •
edited
Loading

Coverage Status

Coverage increased (+1.2%) to 75.082% when pulling 4155674 on add/v2_history into b22f68e on master.

lmsilva-wls
lmsilva-wls reviewed Jul 5, 2021
View reviewed changes
Copy link
Collaborator

@lmsilva-wls lmsilva-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some minor details

app/histories_v2.go Show resolved Hide resolved
app/history_test.go Outdated Show resolved Hide resolved
@flapezoti flapezoti merged commit 6d7e327 into master Jul 5, 2021
@flapezoti flapezoti deleted the add/v2_history branch July 5, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmsilva-wls lmsilva-wls lmsilva-wls approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flapezoti @coveralls @lmsilva-wls