Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprec/remove cassandra from mqtt #33

Merged
merged 8 commits into from
Oct 7, 2022
Merged

Deprec/remove cassandra from mqtt #33

merged 8 commits into from
Oct 7, 2022

Conversation

mflilian
Copy link
Contributor

@mflilian mflilian commented Oct 5, 2022 •
edited
Loading

What?

To deprecate Cassandra infrastructure on MQTT History focusing on maintain only one database(MongoDB) on it.

What was changed?

In the list below you can check some of the modifications that were made to MQTT History for deprecating Cassandra:

  1. Cassandra was removed from docker compose file.
  2. Cassandra was removed from makefile.
  3. Cassandra package was removed.
  4. GoCQL - package responsible for implementing Cassandra client - was removed.
  5. Any code related to Cassandra from the code base (including metrics and tests) was removed.

@coveralls
Copy link

coveralls commented Oct 5, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-1.5%) to 72.184% when pulling 9b62ad8 on deprec/remove-cassandra-from-mqtt into fb016af on master.

bitbanshee
bitbanshee suggested changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@bitbanshee bitbanshee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overwall, great job here!

Since we have only one source of data now, Mongo DB, feature flags such as mongo.enabled can be removed right away from everywhere.

app/app.go Outdated Show resolved Hide resolved
app/histories.go Outdated Show resolved Hide resolved
app/histories_test.go Outdated Show resolved Hide resolved
app/histories_test.go Outdated Show resolved Hide resolved
app/history.go Outdated Show resolved Hide resolved
app/history_test.go Outdated Show resolved Hide resolved
app/history_test.go Outdated Show resolved Hide resolved
app/history_v2_player_support.go Show resolved Hide resolved
models/defaults.go Outdated Show resolved Hide resolved
@thiagomachado
Copy link
Contributor

Hey, the struct Message in model/message.go is a representation of the chat message stored in Cassandra, so it must be removed too. Along with this, some logic to convert a Message into a MessageV2 in mongoclient/get_messages.go that also be removed.

@mflilian mflilian force-pushed the deprec/remove-cassandra-from-mqtt branch from 607e9c4 to ff161ec Compare October 7, 2022 17:40
@bitbanshee
Copy link
Contributor

@bitbanshee bitbanshee closed this Oct 7, 2022
@bitbanshee bitbanshee reopened this Oct 7, 2022
@mflilian mflilian force-pushed the deprec/remove-cassandra-from-mqtt branch from ff161ec to 3b637a1 Compare October 7, 2022 17:45
bitbanshee
bitbanshee approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@bitbanshee bitbanshee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🚀

@mflilian mflilian merged commit 42968f1 into master Oct 7, 2022
@mflilian mflilian self-assigned this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitbanshee bitbanshee bitbanshee approved these changes

@thiagomachado thiagomachado Awaiting requested review from thiagomachado

Assignees

@mflilian mflilian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mflilian @coveralls @thiagomachado @bitbanshee