Created new route offer-info #12
Conversation
This new route retrieves contents and metadata information about an offer instance already seen by the player.
1 similar comment
api/offer_request.go
Outdated
| if playerID == "" { | ||
| err := fmt.Errorf("The player-id parameter cannot be empty") | ||
| logger.WithError(err).Error("Failed to retrieve offer for player.") | ||
| h.App.HandleError(w, http.StatusBadRequest, "The player-id parameter cannot be empty.", err) |
There was a problem hiding this comment.
h.App.HandleError(w, http.StatusBadRequest, err.Error(), err)
There was a problem hiding this comment.
Much better, will fix all of these problems
api/offer_request.go
Outdated
| } else if gameID == "" { | ||
| err := fmt.Errorf("The game-id parameter cannot be empty") | ||
| logger.WithError(err).Error("Failed to retrieve offer for player.") | ||
| h.App.HandleError(w, http.StatusBadRequest, "The game-id parameter cannot be empty.", err) |
There was a problem hiding this comment.
h.App.HandleError(w, http.StatusBadRequest, err.Error(), err)
api/offer_request.go
Outdated
| } else if offerInstanceID == "" { | ||
| err := fmt.Errorf("The offer-id parameter cannot be empty") | ||
| logger.WithError(err).Error("Failed to retrieve offer for player.") | ||
| h.App.HandleError(w, http.StatusBadRequest, "The offer-id parameter cannot be empty.", err) |
There was a problem hiding this comment.
h.App.HandleError(w, http.StatusBadRequest, err.Error(), err)
| return err | ||
| }) | ||
|
|
||
| if err != nil { |
There was a problem hiding this comment.
I think there is an specific error if GetOfferInfo can't find the offer for the given player. In this case you should respond with 404 instead of 500.
There was a problem hiding this comment.
Makes sense, will fix!
docs/source/API.md
Outdated
| } | ||
| ``` | ||
| * Header: | ||
| A max-age header is sent to indicate how long the response returned by get available offers can be cached. |
There was a problem hiding this comment.
... returned by get offer info can be cached.
| QueryStruct(&offerInstance) | ||
| }) | ||
|
|
||
| err = HandleNotFoundError("OfferInstance", map[string]interface{}{ |
|
@cscatolini I made the requested changes, can you take another look? |
This new route retrieves contents and metadata information
about an offer instance already seen by the player.